feat(run): adds Worker Pool support to deploy-cloudrun action#585
feat(run): adds Worker Pool support to deploy-cloudrun action#585matbrito wants to merge 18 commits intogoogle-github-actions:mainfrom
Conversation
|
Thanks for the PR. I'm supportive of adding worker pool (assuming it has been added on the same model as jobs) We are looking for someone at Google to review the PR |
Hi @iennae, thanks for your initial review, i've just made some code changes related to the comments you left. I'm totally open to new comments and suggestions |
|
@matbrito thanks, I'll try to revisit by Friday for a last review. Appreciate your patience here! |
|
A friendly bump just in case it fell through the cracks - supporting this would be awesome 🙏 |
|
please? 😂 |
|
I don't want to be that guy and I know we're welcome to use forks since it's OSS, but I still would like to express my frustration in a friendly way: it's unfortunate that developer experience is an afterthought for Google. You don't even need to implement this, the PR is ready & CLA is signed - click that "Approve Test Suite" button, review, and make a whole bunch of paying customers happier. Just imagine that you're going to spend what - a few hours? - reviewing/merging what's been implemented, and it's going to save so much time everyone that relies on Cloud Run. I know you're busy, probably have other priorities, quarterly goals, and H12026 roadmap is already signed into action... I just hope that there's a spot in there for supporting existing products. |
Add support do worker pool. Some considerations of this PR are placed below: